New Topic

echo and escaped symbols in functions.php

Home › Forum › Bugs › echo and escaped symbols in functions.php

Viewing 5 posts - 1 through 5 (of 5 total)
  • Author
    Posts
  • April 9, 2013 at 9:18 AM #645
    StartupWP
    Keymaster

    The theme will be getting an overall code quality audit soon for all code, in all files. Look for improvements over the next couple of updates.

    Thanks

    May 31, 2013 at 12:54 PM #780
    gwynn
    Participant

    Guys, theme was updated twice after bug report. This is silly bug, and fixing it don’t take more then one minute. But is still present in version 1.1.3 which is released today.
    I think quality audit never come. Source code is totally unreadable. For finding needed hooks, i need beautify it before i can find something.

    May 31, 2013 at 8:26 PM #783
    StartupWP
    Keymaster

    Both the free and pro versions were recently reviewed file by file, line by line by a 3rd unbiased party and given a clean bill of health.

    The theme code is semi-minified/unformatted on purpose, so that isn’t an issue. You’re welcome to open up in your favorite editor and format however you like.

    As far as the “\t\t\t\t” “bug”, we’ll check with development on this right now.

    June 1, 2013 at 12:55 AM #786
    gwynn
    Participant

    The theme code is semi-minified/unformatted on purpose, so that isn’t an issue. You’re welcome to open up in your favorite editor and format however you like.

    Thank you answer.
    But i think, this is wrong way (at least for Pro themes). You make life harder for yours customers. I don’t know anyone who use themes as is, and don’t need customization or child themes. But with ugly code styling – this is much more harder, because i need first format code in readable style.

    June 1, 2013 at 3:13 AM #788
    StartupWP
    Keymaster

    You might still be misunderstanding. The code styling can’t be good or bad, or ugly, because there is no codestyling. Realizing that more in-depth explanation is probably needed here for anyone that wishes to child theme, we’ve gone ahead and written up:

    https://startupwp.com/topic/understanding-the-theme-code/

    Update – Mind you that you’re fully welcome to agree or disagree with our method even after fully understanding, there is nothing further to discuss on this issue as we have no intention of changing this and this topic is no longer constructive. Topic closed. The initial issue you reported has been fixed (won’t see it until 1.1.4) you’ll be happy to hear and we’ll be carefully going over the theme code again to fix definite issues like this.

    Thanks

  • Author
    Posts
Viewing 5 posts - 1 through 5 (of 5 total)
  • The topic ‘echo and escaped symbols in functions.php’ is closed to new replies.